From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Wed, 19 Feb 2020 12:20:05 +0000 (-0300)
Subject: appDisplay: Remove unnecessary bind constraint
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~772^2^2~100
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b8f8e1710bcdd3bc5d07d5cefc6c3ab97b04c10d;p=gnome-shell.git

appDisplay: Remove unnecessary bind constraint

Now that the bind constraint changes the preferred size of
the actor, a major flaw in the AppDisplay code was exposed:
the folder dialog depends on the preferred size of a parent,
and the parent depends on the preferred size of the folder
dialog.

While we know this is not actually true, we shouldn't rely
on broken behavior to achieve this result. What's interesting
is that the bind constraint used by the folder dialog is a
relic of the development phase; we now control the position
and size of the dialog with a combination of CSS, and alignment.

Remove the unnecessary bind constraint.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1027
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 01f87059a..a602ba65d 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1657,10 +1657,6 @@ var AppFolderDialog = GObject.registerClass({
             x_align: Clutter.ActorAlign.CENTER,
             y_align: Clutter.ActorAlign.CENTER,
         });
-        this.add_constraint(new Clutter.BindConstraint({
-            source: Main.overview.viewSelector,
-            coordinate: Clutter.BindCoordinate.ALL,
-        }));
 
         this._source = source;
         this._folder = folder;